🌐 AI搜索 & 代理 主页
Skip to content

Bug: [await-thenable] inconsistent behavior on promise unions #11609

@abrahamguo

Description

@abrahamguo

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.9.2&fileType=.ts&code=MYewdgzgLgBAtgQwJ4CMCmAFATiOBLCNGAXhgFkEoALAOiwTABNcAKAShgH4ZtcC06aCCAA2ANzTsYALhgBGANwAoJQgDuCPLESpMOfIQUwA9MZhYAriKLMhMMCFhY0ABxBYoK3gYEIRIlgBtHXRvfgBdNiNTcysiZzcPCBU0AA9E2ABvAF8FIA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6AQwHd3K78ALRE3YAjJOiiJo0APbRI4MAF8QSoA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

const maybePromise = Math.random() ? Promise.resolve() : 1;

await maybePromise; // rule does not report

Promise.all([maybePromise]); // rule reports

export {};

ESLint Config

{
  "rules": {
    "@typescript-eslint/await-thenable": "error"
  }
}

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true
  }
}

Expected Result

The rule should not report.

Actual Result

The rule reports on passing maybePromise into Promise.all.

Additional Info

In #11267, @ronami added support for non-promise values passed to aggregator methods.

However, this now introduces an inconsistency:

  • The rule correctly does not report when awaiting something that might be a Promise.
  • However, the rule wrongly reports when passing something that might be a Promise into a promise aggregator function.

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workingpackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions