From c80d100ed852225e1c39f26ddc34957d12f44325 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Josh=20Goldberg=20=E2=9C=A8?= Date: Mon, 29 Sep 2025 14:25:35 -0400 Subject: [PATCH] Revert "feat(eslint-plugin): expose rule name via RuleModule interface (#11616)" This reverts commit f2eeb9d9f354fc1fe5ba22272ad2dc747cec0c1d. --- .../rules/no-unused-vars/no-unused-vars-eslint.test.ts | 1 - .../tests/rules/no-unused-vars/no-unused-vars.test.ts | 1 - packages/rule-tester/tests/RuleTester.test.ts | 6 ------ packages/rule-tester/tests/filename.test.ts | 1 - packages/utils/src/eslint-utils/RuleCreator.ts | 4 ---- packages/utils/src/ts-eslint/Rule.ts | 5 ----- 6 files changed, 18 deletions(-) diff --git a/packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars-eslint.test.ts b/packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars-eslint.test.ts index aa1fb5b9b018..d05d538d2731 100644 --- a/packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars-eslint.test.ts +++ b/packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars-eslint.test.ts @@ -40,7 +40,6 @@ ruleTester.defineRule('use-every-a', { schema: [], type: 'problem', }, - name: 'use-every-a', }); /** diff --git a/packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars.test.ts b/packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars.test.ts index 10014dcc66d7..5f40bbcdc3cc 100644 --- a/packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars.test.ts +++ b/packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars.test.ts @@ -32,7 +32,6 @@ ruleTester.defineRule('collect-unused-vars', { schema: [], type: 'problem', }, - name: 'collect-unused-vars', }); ruleTester.run('no-unused-vars', rule, { diff --git a/packages/rule-tester/tests/RuleTester.test.ts b/packages/rule-tester/tests/RuleTester.test.ts index 054986010bc9..73a5a05d45cf 100644 --- a/packages/rule-tester/tests/RuleTester.test.ts +++ b/packages/rule-tester/tests/RuleTester.test.ts @@ -94,7 +94,6 @@ const NOOP_RULE: RuleModule<'error'> = { schema: [], type: 'problem', }, - name: 'rule', }; function windowsToPosixPath(p: string): string { @@ -1109,7 +1108,6 @@ describe('RuleTester - hooks', () => { schema: [], type: 'problem', }, - name: 'rule', }; const ruleTester = new RuleTester(); @@ -1333,7 +1331,6 @@ describe('RuleTester - multipass fixer', () => { schema: [], type: 'problem', }, - name: 'rule', }; it('passes with no output', () => { @@ -1419,7 +1416,6 @@ describe('RuleTester - multipass fixer', () => { schema: [], type: 'problem', }, - name: 'rule', }; it('passes with correct string output', () => { @@ -1542,7 +1538,6 @@ describe('RuleTester - multipass fixer', () => { schema: [], type: 'problem', }, - name: 'rule', }; it('passes with correct array output', () => { @@ -1649,7 +1644,6 @@ describe('RuleTester - run types', () => { ], type: 'suggestion', }, - name: 'rule', }; describe('infer from `rule` parameter', () => { diff --git a/packages/rule-tester/tests/filename.test.ts b/packages/rule-tester/tests/filename.test.ts index 943ab1894a38..8f3442cf670a 100644 --- a/packages/rule-tester/tests/filename.test.ts +++ b/packages/rule-tester/tests/filename.test.ts @@ -19,7 +19,6 @@ const rule = ESLintUtils.RuleCreator.withoutDocs({ type: 'problem', hasSuggestions: true, }, - name: 'rule', defaultOptions: [], create: context => ({ Program(node): void { diff --git a/packages/utils/src/eslint-utils/RuleCreator.ts b/packages/utils/src/eslint-utils/RuleCreator.ts index 57ab282c3632..cd06aee6231f 100644 --- a/packages/utils/src/eslint-utils/RuleCreator.ts +++ b/packages/utils/src/eslint-utils/RuleCreator.ts @@ -36,7 +36,6 @@ export interface RuleWithMeta< Docs = unknown, > extends RuleCreateAndOptions { meta: RuleMetaData; - name: string; } export interface RuleWithMetaAndName< @@ -77,7 +76,6 @@ export function RuleCreator( url: urlCreator(name), }, }, - name, ...rule, }); }; @@ -91,7 +89,6 @@ function createRule< create, defaultOptions, meta, - name, }: Readonly>): RuleModule< MessageIds, Options, @@ -104,7 +101,6 @@ function createRule< }, defaultOptions, meta, - name, }; } diff --git a/packages/utils/src/ts-eslint/Rule.ts b/packages/utils/src/ts-eslint/Rule.ts index be28d4a0b9ec..1a4920a3e79e 100644 --- a/packages/utils/src/ts-eslint/Rule.ts +++ b/packages/utils/src/ts-eslint/Rule.ts @@ -735,11 +735,6 @@ export interface RuleModule< * Metadata about the rule */ meta: RuleMetaData; - - /** - * Rule name - */ - name: string; } export type AnyRuleModule = RuleModule;