fix: code actions handling #1009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sync code actions handling with upstream - make returned code action "kind" values more specific. - Fix matching of client-provided `only` values. It only worked if client provided for example `only: ["refactor"]` but not if client provided `only: ["refactor.move"]`. - Make separate code actions request to TS for each "only" kind that the client has passed. Previously we'd only make request for the first one. - Add test for "Move to file" interactive code action.
Contributor
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onlyvalues. It only worked if client provided for exampleonly: ["refactor"]but not if client providedonly: ["refactor.move"].Fixes #954