🌐 AI搜索 & 代理 主页
Skip to content

Commit 67c4837

Browse files
eggrobineggrobin
authored
Tweak the addition comparison tests based on 18.0 experience (#1257)
* Update the comment to avoid implying that already-encoded characters are provisionally assigned * filtering * quote
1 parent 77ff991 commit 67c4837

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

49 files changed

+162
-49
lines changed

‎docs/pipeline.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,8 +241,8 @@ git commit -m GenerateEnums
241241

242242
### Run comparison tests
243243

244-
eggrobin (Windows, in-source).
244+
eggrobin (Windows, in-source; replace $RMG_ISSUE by the RMG issue number, or define it as that number).
245245
```powershell
246-
mvn test -am -pl unicodetools "-DCLDR_DIR=$(gl|split-path -parent)\cldr\" "-DUNICODETOOLS_GEN_DIR=$(gl|split-path -parent)\unicodetools\Generated\" "-DUNICODETOOLS_REPO_DIR=$(gl|split-path -parent)\unicodetools\" "-DUVERSION=18.0.0" "-Dtest=TestTestUnicodeInvariants#testAdditionComparisons" -DfailIfNoTests=false -DtrimStackTrace=false
246+
mvn test -am -pl unicodetools "-DCLDR_DIR=$(gl|split-path -parent)\cldr\" "-DUNICODETOOLS_GEN_DIR=$(gl|split-path -parent)\unicodetools\Generated\" "-DUNICODETOOLS_REPO_DIR=$(gl|split-path -parent)\unicodetools\" "-DUVERSION=18.0.0" "-Dtest=TestTestUnicodeInvariants#testAdditionComparisons" -DfailIfNoTests=false -DtrimStackTrace=false "-DRMG_ISSUE=$RMG_ISSUE"
247247
```
248248
Results are in Generated\UnicodeTestResults-addition-comparisons-[RMG issue number].html.

‎unicodetools/src/main/resources/org/unicode/text/UCD/AdditionComparisons/118.txt‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@ Let $OldNoons := [ ن ڹ ں ڻ ڼ ڽ ݧ ݨ ݩ ࢉ ]
77
# Age always differs since these tests are comparing additions to pre-existing characters.
88
Ignoring Name Age:
99

10-
# Ignore the security and IDNA properties, as these are not yet included for provisionally assigned characters.
10+
# Ignore the security and IDNA properties. These are not part of the UCD, and
11+
# are typically prepared just before β, after these tests are written (which is
12+
# normally anywhere between proposal submission and the start of α).
1113
Ignoring Confusable_MA Identifier_Status Identifier_Type Idn_Status Idn_Mapping Idn_2008:
1214

1315
Ignoring Block Unicode_1_Name Arabic_Shaping_Schematic_Name:

‎unicodetools/src/main/resources/org/unicode/text/UCD/AdditionComparisons/120.txt‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
# Age always differs since these tests are comparing additions to pre-existing characters.
66
Ignoring Name Age:
77

8-
# Ignore the security and IDNA properties, as these are not yet included for provisionally assigned characters.
8+
# Ignore the security and IDNA properties. These are not part of the UCD, and
9+
# are typically prepared just before β, after these tests are written (which is
10+
# normally anywhere between proposal submission and the start of α).
911
Ignoring Confusable_MA Identifier_Status Identifier_Type Idn_Status Idn_Mapping Idn_2008 IDNA2008_Category:
1012

1113
Propertywise [\N{BENGALI SIGN COMBINING ANUSVARA ABOVE} \N{BENGALI SIGN CANDRABINDU}] AreAlike

‎unicodetools/src/main/resources/org/unicode/text/UCD/AdditionComparisons/125.txt‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
# Age always differs since these tests are comparing additions to pre-existing characters.
66
Ignoring Name Age:
77

8-
# Ignore the security and IDNA properties, as these are not yet included for provisionally assigned characters.
8+
# Ignore the security and IDNA properties. These are not part of the UCD, and
9+
# are typically prepared just before β, after these tests are written (which is
10+
# normally anywhere between proposal submission and the start of α).
911
Ignoring Confusable_MA Identifier_Status Identifier_Type Idn_Status Idn_Mapping Idn_2008 IDNA2008_Category:
1012

1113
# Modifier ꞕ separately below because its non-modifier counterpart is out of

‎unicodetools/src/main/resources/org/unicode/text/UCD/AdditionComparisons/126.txt‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
# Age always differs since these tests are comparing additions to pre-existing characters.
66
Ignoring Name Age:
77

8-
# Ignore the security and IDNA properties, as these are not yet included for provisionally assigned characters.
8+
# Ignore the security and IDNA properties. These are not part of the UCD, and
9+
# are typically prepared just before β, after these tests are written (which is
10+
# normally anywhere between proposal submission and the start of α).
911
Ignoring Confusable_MA Identifier_Status Identifier_Type Idn_Status Idn_Mapping Idn_2008 IDNA2008_Category:
1012

1113
Ignoring Block:

‎unicodetools/src/main/resources/org/unicode/text/UCD/AdditionComparisons/127.txt‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
# Age always differs since these tests are comparing additions to pre-existing characters.
66
Ignoring Name Age:
77

8-
# Ignore the security and IDNA properties, as these are not yet included for provisionally assigned characters.
8+
# Ignore the security and IDNA properties. These are not part of the UCD, and
9+
# are typically prepared just before β, after these tests are written (which is
10+
# normally anywhere between proposal submission and the start of α).
911
Ignoring Confusable_MA Identifier_Status Identifier_Type Idn_Status Idn_Mapping Idn_2008 IDNA2008_Category:
1012

1113
Ignoring Block Math_Entity_Name:

‎unicodetools/src/main/resources/org/unicode/text/UCD/AdditionComparisons/128.txt‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
# Age always differs since these tests are comparing additions to pre-existing characters.
66
Ignoring Name Age:
77

8-
# Ignore the security and IDNA properties, as these are not yet included for provisionally assigned characters.
8+
# Ignore the security and IDNA properties. These are not part of the UCD, and
9+
# are typically prepared just before β, after these tests are written (which is
10+
# normally anywhere between proposal submission and the start of α).
911
Ignoring Confusable_MA Identifier_Status Identifier_Type Idn_Status Idn_Mapping Idn_2008 IDNA2008_Category:
1012

1113
Ignoring Block:

‎unicodetools/src/main/resources/org/unicode/text/UCD/AdditionComparisons/129.txt‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
# Age always differs since these tests are comparing additions to pre-existing characters.
66
Ignoring Name Age:
77

8-
# Ignore the security and IDNA properties, as these are not yet included for provisionally assigned characters.
8+
# Ignore the security and IDNA properties. These are not part of the UCD, and
9+
# are typically prepared just before β, after these tests are written (which is
10+
# normally anywhere between proposal submission and the start of α).
911
Ignoring Confusable_MA Identifier_Status Identifier_Type Idn_Status Idn_Mapping Idn_2008 IDNA2008_Category:
1012

1113
Ignoring Block:

‎unicodetools/src/main/resources/org/unicode/text/UCD/AdditionComparisons/137.txt‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
# Age always differs since these tests are comparing additions to pre-existing characters.
66
Ignoring Name Age:
77

8-
# Ignore the security and IDNA properties, as these are not yet included for provisionally assigned characters.
8+
# Ignore the security and IDNA properties. These are not part of the UCD, and
9+
# are typically prepared just before β, after these tests are written (which is
10+
# normally anywhere between proposal submission and the start of α).
911
Ignoring Confusable_MA Identifier_Status Identifier_Type Idn_Status Idn_Mapping Idn_2008 IDNA2008_Category:
1012

1113
Ignoring kRSTUnicode kTGT_MergedSrc kJURC_NCReading kJURC_Numeric kJURC_RSUnicode kJURC_Src:

‎unicodetools/src/main/resources/org/unicode/text/UCD/AdditionComparisons/139.txt‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
# Age always differs since these tests are comparing additions to pre-existing characters.
66
Ignoring Name Age:
77

8-
# Ignore the security and IDNA properties, as these are not yet included for provisionally assigned characters.
8+
# Ignore the security and IDNA properties. These are not part of the UCD, and
9+
# are typically prepared just before β, after these tests are written (which is
10+
# normally anywhere between proposal submission and the start of α).
911
Ignoring Confusable_MA Identifier_Status Identifier_Type Idn_Status Idn_Mapping Idn_2008 IDNA2008_Category:
1012

1113
Ignoring Block:

0 commit comments

Comments
 (0)