Report skipped hermione tests #697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add missing skipped spec fixture
vovsemenv
suggested changes
Jun 13, 2023
| describe("with skip", () => { | ||
| it.skip("should be skipped", () => {}); | ||
| }); | ||
|
|
Contributor
There was a problem hiding this comment.
maybe we also need fixture for the describe.skip?
Member
Author
There was a problem hiding this comment.
They actually have problem with tests only, let's keep this implementation only for tests and add suites handling later
| hermione.on(hermione.events.AFTER_TESTS_READ, (collection) => { | ||
| // cache all the tests to handle skipped tests in future | ||
| collection.eachTest((test) => { | ||
| loadedTests.set(test.fullTitle(), test); |
Contributor
There was a problem hiding this comment.
test.fullTitle() is not unique value
this two tests have same fullTitle
describe("desc", function () {
it("it", () => {});
it("it", () => {});
});
| const hostname = os.hostname(); | ||
|
|
||
| const hermioneAllureReporter = (hermione: Hermione, opts: AllureReportOptions) => { | ||
| const loadedTests = new Map<string, Hermione.Test>(); |
Contributor
There was a problem hiding this comment.
We don't really need Map in this case. Lets use Set maybe?
Member
Author
There was a problem hiding this comment.
Make id's uniq, but keep Map
baev
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
fixes #653
Checklist