fix(oidc-provider): resolve getSignedCookie return type #6346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bytaesu is attempting to deploy a commit to the better-auth Team on Vercel. A member of the Team first needs to authorize it. |
better-auth
@better-auth/cli
@better-auth/core
@better-auth/expo
@better-auth/passkey
@better-auth/scim
@better-auth/sso
@better-auth/stripe
@better-auth/telemetry
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a type handling issue with the getSignedCookie method in the OIDC provider plugin. The method returns a nullable value (string | null | undefined), but the previous code was directly assigning its result to consentCode without proper null checking, which could cause type errors.
Key changes:
- Properly handles the nullable return type of
getSignedCookieby assigning to an intermediate variable and checking for truthiness before use
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
This PR resolves all remaining type mismatches from the |
Bekacru
approved these changes
Nov 27, 2025
Bekacru
pushed a commit
that referenced
this pull request
Nov 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return type updated -> better-auth/better-call#81
Summary by cubic
Handled nullable return from getSignedCookie in the OIDC consent flow. We now set consentCode only when the "oidc_consent_prompt" cookie exists, resolving type errors and preventing undefined assignments.
Written for commit 4d5853c. Summary will update automatically on new commits.