🌐 AI搜索 & 代理 主页
Skip to content

test: fix an assertion failure #19500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdjermanovic merged 2 commits into from
Mar 11, 2025
Merged

test: fix an assertion failure #19500

mdjermanovic merged 2 commits into from
Mar 11, 2025

Conversation

@fisker
Copy link
Contributor

@fisker fisker commented Mar 11, 2025 •
edited
Loading

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

This test won't pass on local

What changes did you make? (Give an overview)

When I work on #19499, I noticed this test won't pass.

The actual error is

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
actual expected

"Av'somethid using variables named 'foo'." (WITH COLORS)

I guess it passed because it's different on CI.

Is there anything you'd like reviewers to focus on?

No.

@fisker fisker requested a review from a team as a code owner March 11, 2025 07:17
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Mar 11, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Mar 11, 2025
@netlify
Copy link

netlify bot commented Mar 11, 2025 •
edited
Loading

✅ Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 0bbba8e
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67d053ae6e2dea0008991ac8
😎 Deploy Preview https://deploy-preview-19500--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fisker fisker changed the title test: fix an assert failure test: fix an assertion failure Mar 11, 2025
mdjermanovic
mdjermanovic reviewed Mar 11, 2025
View reviewed changes
@mdjermanovic mdjermanovic moved this from Needs Triage to Implementing in Triage Mar 11, 2025
@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Mar 11, 2025
@fisker @mdjermanovic
Update tests/lib/rule-tester/rule-tester.js
0bbba8e 
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
mdjermanovic
mdjermanovic approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 9c5c6ee into eslint:main Mar 11, 2025
30 checks passed
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Mar 11, 2025
@fisker fisker deleted the assert-error branch March 11, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees

No one assigned

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing

Projects

Triage
Status: Complete

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fisker @mdjermanovic