fix: changelog-host parameter ignored when using manifest configuration
#1151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When release-please-config.json is used, the changelog-host input parameter was being ignored and not passed to Manifest.fromManifest(). This caused changelog links to default to https://github.com instead of the specified custom host (e.g., GitHub Enterprise instances). - Add changelogHost to manifestOverrides when it differs from default - Restructure manifestOverrides logic to handle all overrides consistently - Add test case to verify changelog-host is properly passed to manifest Fixes issue where GitHub Enterprise users couldn't customize changelog links when using manifest configuration files.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
ferrarimarco
requested changes
Sep 15, 2025
Collaborator
ferrarimarco
left a comment
There was a problem hiding this comment.
Thanks for this PR, a couple of things to check.
This was referenced Sep 17, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
🤖 I have created a release *beep* *boop* --- ## [4.4.0](v4.3.0...v4.4.0) (2025-10-09) ### Features * add ability to select versioning-strategy and release-as ([#1121](#1121)) ([ee0f5ba](ee0f5ba)) ### Bug Fixes * `changelog-host` parameter ignored when using manifest configuration ([#1151](#1151)) ([535c413](535c413)) * bump mocha from 11.7.1 to 11.7.2 in the npm_and_yarn group across 1 directory ([#1149](#1149)) ([3612a99](3612a99)) * bump release-please from 17.1.2 to 17.1.3 ([#1158](#1158)) ([66fbfe9](66fbfe9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
software-dev-web
added a commit
to software-dev-web/please-action
that referenced
this pull request
Dec 11, 2025
🤖 I have created a release *beep* *boop* --- ## [4.4.0](googleapis/release-please-action@v4.3.0...v4.4.0) (2025-10-09) ### Features * add ability to select versioning-strategy and release-as ([#1121](googleapis/release-please-action#1121)) ([ee0f5ba](googleapis/release-please-action@ee0f5ba)) ### Bug Fixes * `changelog-host` parameter ignored when using manifest configuration ([#1151](googleapis/release-please-action#1151)) ([535c413](googleapis/release-please-action@535c413)) * bump mocha from 11.7.1 to 11.7.2 in the npm_and_yarn group across 1 directory ([#1149](googleapis/release-please-action#1149)) ([3612a99](googleapis/release-please-action@3612a99)) * bump release-please from 17.1.2 to 17.1.3 ([#1158](googleapis/release-please-action#1158)) ([66fbfe9](googleapis/release-please-action@66fbfe9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
changelog-hostaction parameter was being ignored when using manifest configuration files (release-please-config.json). This caused changelog links to always point togithub.cominstead of the specified GitHub Enterprise Server URL, breaking changelog functionality for GitHub Enterprise users.Root Cause
The original implementation attempted to pass
changelogHostthroughmanifestOverridesto theManifest.fromManifest()method. However,changelogHostis not part of theManifestOptionsinterface - it belongs to the per-pathReleaserConfiginterface. This architectural mismatch meant the parameter was silently ignored.Solution
Modified the
loadOrBuildManifest()function to:changelogHostthrough manifest optionschangelogHostfor all configured paths when the action input is provided and differs from the default GitHub URLTechnical Details
manifestOverrides.changelogHost(invalid approach)manifest.repositoryConfig[path].changelogHostfor each path after manifest loadingchangelog-hostinput is provided and differs fromhttps://github.comTesting
Impact
This fix enables GitHub Enterprise Server users to properly use the
changelog-hostparameter with manifest configurations, ensuring changelog links point to their custom Git hosting instead