WebGL / Fix incorrect scaling of colors when provided by a style variable #16836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-16836--ol-site.netlify.app/. |
ef0b6b6 to
e000cad
Compare
This is mainly for consistency and readability
e000cad to
e586b3f
Compare
e586b3f to
3650b7b
Compare
tschaub
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, colors provided through variables (and read with e.g.
['var', 'myColor']) were not scaled to the 0-1 range before being sent to the GPU.This means that:
Example of the issue without the change:
After the fix:
Fixes #16510
This PR also contains a slight refactoring of the ShaderBuilder to make handling of Uniforms and Attributes more similar.