Inference of generic method type arguments based on returns and parameter passing #1226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1226 +/- ##
============================================
+ Coverage 88.32% 88.36% +0.03%
- Complexity 2358 2366 +8
============================================
Files 89 89
Lines 7669 7693 +24
Branches 1535 1540 +5
============================================
+ Hits 6774 6798 +24
Misses 450 450
Partials 445 445 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yuxincs
approved these changes
Jun 30, 2025
haewiful
pushed a commit
to haewiful/NullAway01
that referenced
this pull request
Aug 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We extract the logic from #1131 to also handle returns of calls to generic methods or passing a generic method call result as a parameter. If the parameter or return type being assigned to is
@Nullable, and the generic method's return type is a type variable, don't infer anything, as the type argument could be either@Nullableor@NonNull.Also includes a small logic cleanup for handling of varargs in
GenericsChecks.