Update to Error Prone 2.41.0 #1239

msridhar · 2025-08-07T18:32:09Z

Almost all the code fixes are for the new EffectivelyPrivate check.

Summary by CodeRabbit

Chores
- Updated Error Prone version to 2.41.0 across all environments.
Refactor
- Improved internal code encapsulation by restricting visibility of constructors, fields, and methods in multiple components without affecting user-facing functionality.
Tests
- Added test annotation to a suppression suggestion test method for improved test execution.

coderabbitai · 2025-08-07T18:32:17Z

Walkthrough

The changes update the Error Prone version from 2.39.0 to 2.41.0 in the CI workflow and Gradle dependencies. Multiple Java classes have their constructor and method visibility reduced from public to package-private, affecting several inner and nested classes and fields. A test method was annotated with @test and had its throws declaration removed. No logic or control flow is altered.

Changes

Cohort / File(s)	Change Summary
CI Workflow Update `.github/workflows/continuous-integration.yml`	Updated Error Prone version from 2.39.0 to 2.41.0 in the workflow matrix and jacoco coverage step condition.
Gradle Dependency Version `gradle/dependencies.gradle`	Changed `latestErrorProneVersion` from "2.39.0" to "2.41.0", updating related variables.
Library Model Generator Constructor Visibility `library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java`	Removed `public` modifier from constructors of `AnnotationCollectorCallback` and `AnnotationCollectionVisitor` inner classes.
CodeAnnotationInfo ClassCacheRecord Visibility `nullaway/src/main/java/com/uber/nullaway/CodeAnnotationInfo.java`	Changed all members, constructor, and method of `ClassCacheRecord` from public to package-private.
AccessPath Inner Class Constructor Visibility `nullaway/src/main/java/com/uber/nullaway/dataflow/AccessPath.java`	Changed constructors of `StringMapKey` and `NumericMapKey` from public to package-private.
ApacheThriftIsSetHandler Inner Class Constructor Visibility `nullaway/src/main/java/com/uber/nullaway/handlers/ApacheThriftIsSetHandler.java`	Changed constructor of `FieldAndGetterElements` from public to package-private.
LibraryModelsHandler Constructor & Method Visibility `nullaway/src/main/java/com/uber/nullaway/handlers/LibraryModelsHandler.java`	Removed public modifier from constructors and several methods in `CombinedLibraryModels`, `OptimizedLibraryModels`, and `NameIndexedMap` inner class.
OptionalEmptinessHandler Field Visibility `nullaway/src/main/java/com/uber/nullaway/handlers/OptionalEmptinessHandler.java`	Changed visibility of `contextKey` field in `OptionalContentVariableElement` from public static final to package-private static final.
Test Method Annotation Update `nullaway/src/test/java/com/uber/nullaway/AutoSuggestTest.java`	Added `@Test` annotation and removed `throws IOException` from `suggestInitSuppressionOnConstructor` method.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 881f26a and 234d30f.

📒 Files selected for processing (1)

nullaway/src/test/java/com/uber/nullaway/AutoSuggestTest.java (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

GitHub Check: JDK 17 on ubuntu-latest with Error Prone 2.41.0
GitHub Check: JDK 11 on ubuntu-latest with Error Prone 2.14.0
GitHub Check: JDK 11 on ubuntu-latest with Error Prone 2.31.0
GitHub Check: JDK 17 on ubuntu-latest with Error Prone 2.14.0
GitHub Check: JDK 17 on windows-latest with Error Prone 2.41.0
GitHub Check: JDK 17 on macos-latest with Error Prone 2.41.0
GitHub Check: Build Caffeine with snapshot

🔇 Additional comments (1)

nullaway/src/test/java/com/uber/nullaway/AutoSuggestTest.java (1)

321-322: All set: @test added & IOException declaration is no longer needed.

The @Test annotation is required for JUnit to pick up this method. After upgrading to Error Prone 2.41.0, the refactoring helper’s addInputLines/addOutputLines and doTest() no longer throw IOException, so removing the throws IOException is correct.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch ep-2.41.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

msridhar · 2025-08-07T18:32:38Z

We'll need to update required CI job names before landing @yuxincs

codecov · 2025-08-07T19:00:05Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.44%. Comparing base (dc07f65) to head (234d30f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #1239   +/-   ##
=========================================
  Coverage     88.44%   88.44%           
  Complexity     2373     2373           
=========================================
  Files            90       90           
  Lines          7786     7786           
  Branches       1555     1555           
=========================================
  Hits           6886     6886           
  Misses          453      453           
  Partials        447      447

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

yuxincs

Nice, required CI jobs updated!

Almost all the code fixes are for the new [EffectivelyPrivate](https://errorprone.info/bugpattern/EffectivelyPrivate) check.  ## Summary by CodeRabbit * **Chores** * Updated Error Prone version to 2.41.0 across all environments. * **Refactor** * Improved internal code encapsulation by restricting visibility of constructors, fields, and methods in multiple components without affecting user-facing functionality. * **Tests** * Added test annotation to a suppression suggestion test method for improved test execution.

Update to Error Prone 2.41.0

881f26a

msridhar requested a review from yuxincs August 7, 2025 18:32

Fix another warning

234d30f

yuxincs approved these changes Aug 7, 2025

View reviewed changes

msridhar merged commit 92c9304 into master Aug 7, 2025
13 checks passed

msridhar deleted the ep-2.41.0 branch August 7, 2025 19:52

coderabbitai bot mentioned this pull request Sep 1, 2025

Simplified set of CI jobs #1271

Merged

coderabbitai bot mentioned this pull request Sep 19, 2025

Update to Error Prone 2.42.0 #1299

Merged

coderabbitai bot mentioned this pull request Oct 4, 2025

Generate astubx from JSON output of jdk-javac-plugin #1243

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update to Error Prone 2.41.0 #1239

Update to Error Prone 2.41.0 #1239

Uh oh!

msridhar commented Aug 7, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Aug 7, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

msridhar commented Aug 7, 2025

Uh oh!

codecov bot commented Aug 7, 2025 •

edited

Loading

Uh oh!

yuxincs left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Update to Error Prone 2.41.0 #1239

Update to Error Prone 2.41.0 #1239

Uh oh!

Conversation

msridhar commented Aug 7, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

msridhar commented Aug 7, 2025

Uh oh!

codecov bot commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

yuxincs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

msridhar commented Aug 7, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 7, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Aug 7, 2025 •

edited

Loading