-
-
Notifications
You must be signed in to change notification settings - Fork 172
fix: log Output of Failed Process #974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Consequently, I would like to name the log file the same as its corresponding environment directory. Since neither I don't know whether that needs testing, though. 🤔 |
theacodes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm supportive of the feature added in this PR, but there seems to be a lot of unrelated changes that stringify annotations.
…derr` Previously, there was no way to capture the output of a failed `pytest` run from within `noxfile.py`
8ab668f to
3b74bff
Compare
3b74bff to
c8b2dd3
Compare
|
Hey @theacodes, thanks for your time! I applied the needed code changes by rebasing on |
|
Looks good! I'd love for @henryiii to take a look if he's up for it. :) |
|
Much better looking diff now. :) I think it looks good, I'd be even up to getting this into #1010, I think. |
|
Though the linter/coverage issue needs fixing. |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Is |
Yes, it is:
My definition of But, I don't know whether this is relevant in practice. |
|
@henryiii Thank you, too, for reviewing and adding the last test as well! |
|
While we are at it: We now have @theacodes @henryiii Shall I rename |
Hi there 👋,
I started using
noxfor matrix testing inelvaand got a workingnoxfile.pyin no time.Very nice ❤️
Since there are many sessions, I want to write session-specific logs.
However, there was no way to capture the output of a failed
pytestrun to see what went wrong.So, here is my patch to overcome this.
Basically, the output of a failed process is no longer written to
sys.stderrsolely but instead by the session logger vialogger.error.Before, any output logging was prevented by a raised
CommandFailedexception.This whole story is somewhat related to issue #409.
The difference is that I didn't need to use
asyncioinpopen.That is the current state of my
noxfile.pyWhat do you think?