Add vue/no-deprecated-destroyed-lifecycle rule
#1211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sosukesuzuki
left a comment
There was a problem hiding this comment.
Disclaimer: I'm a not maintainer.
| ` | ||
| } | ||
| ], | ||
| invalid: [ |
Contributor
There was a problem hiding this comment.
Should we add tests for computed properties? I'm not sure if this is a expected behavior but current implementation also warn for below code:
export default {
["destroyed"]() {}
}
Member
Author
There was a problem hiding this comment.
Thank you for your review!
It is the expected behavior to report. But I should add a test case. In especially, I should test if suggest works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
vue/no-deprecated-destroyed-lifecyclerule.The
vue/no-deprecated-destroyed-lifecyclerule reports use of deprecateddestroyedandbeforeDestroylifecycle hooks.