⭐️New: Add rule no-duplicate-attr-inheritance
#627
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ticket: #626 |
armano2
suggested changes
Nov 3, 2018
Contributor
armano2
left a comment
There was a problem hiding this comment.
What we should do with mixins and extend? property can be set inside them.
Co-Authored-By: hirokiosame <hiroki.osame@gmail.com>
Contributor
Author
|
@armano2
|
Member
|
Thanks for working on it @hirokiosame , however I'm going to close this PR for the moment, until we decide whether it's something we want to consider. Let's continue discussion in the relevant issue: #626 |
armano2
approved these changes
Nov 11, 2018
ota-meshi
added a commit
that referenced
this pull request
May 20, 2020
* Added no-duplicate-attr-inheritence rule * New rule no-duplicate-attr-inheritance * New rule no-duplicate-attr-inheritance * Code to work with Node v6.14.4 * Remove category Co-Authored-By: hirokiosame <hiroki.osame@gmail.com> * Update Co-authored-by: Hiroki Osame <hiroki@weebly.com> Co-authored-by: Armano <armano2@users.noreply.github.com> Co-authored-by: hirokiosame <hiroki.osame@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule makes sure you're setting
inheritAttrstofalsewhen it detectsv-bind="$attrs".This rule is to prevent duplicated attribute inheritance: http://jsfiddle.net/hirokiosame/h0j3qrbm/
Can update the docs if there's consensus on the rule proposal.