Adding kanagawa paper theme #854
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds the "kanagawa-paper" theme to the theme collection and implements alphabetical sorting of themes in the demo page. The PR also includes an "oceanic-next" theme addition, though this was not mentioned in the title.
- Added "kanagawa-paper" theme with appropriate color scheme
- Added "oceanic-next" theme with appropriate color scheme
- Implemented alphabetical sorting of themes in the demo dropdown
- Applied code formatting improvements (foreach syntax consistency, whitespace cleanup)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/themes.php | Adds two new theme definitions: "oceanic-next" and "kanagawa-paper" with color configurations |
| src/demo/index.php | Implements alphabetical theme sorting via ksort() and applies code formatting improvements to foreach statements and whitespace |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #830
Type of change
How Has This Been Tested?
Checklist:
Screenshots