Enable config override via public/config.js #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
default to remote config also DRY
MarekSuchanek
approved these changes
Mar 13, 2025
Contributor
MarekSuchanek
left a comment
There was a problem hiding this comment.
Looks good... maybe there could be some separation or extra comment before the loading of "config values" that cannot be specified via config.js (currently resourceDefinitions)
Contributor
Author
|
Thanks for the review @MarekSuchanek. I added another comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote config obtained from FDP API
/configs/bootstrapremains the default, but can be overridden using apublic/config.jsfilefixes #171