python313Packages.tkinter: fix build for python 3.10 and 3.11, enable tests #442184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55a8771 to
610c3bc
Compare
610c3bc to
d38339f
Compare
dotlambda
reviewed
Sep 15, 2025
Tcl 9.0 support in Tkinter is not quite there yet [1]. There is ongoing work on improving support, though. This fixes the build of `python310Packages.tkinter` and `python311Packages.tkinter`. [1] python/cpython#124111
6f8a4f3 to
69b8cd9
Compare
13 tasks
13 tasks
mweinelt
approved these changes
Sep 24, 2025
Member
|
I still can't rebuild my system even if this is merged and has been for a good while, has this not hit nixos-unstable? |
Member
|
It's still waiting in staging for the next cycle to begin. https://nixpk.gs/pr-tracker.html?pr=442184 |
Member
|
@mweinelt My bad, the PR tracker didn't wanna work at all for me. Also, what do you mean it's waiting for the next cycle to begin? The next NixOS release cycle? You mean until November? |
Member
|
The staging branch accumulates expensive rebuilds, which get processed in batch on the staging-next branch. These cycles take roughly two weeks each. |
Member
|
Ohh, so because it's a dependency of so many things it's taking much longer to reach |
13 tasks
dotlambda
added a commit
to dotlambda/nixpkgs
that referenced
this pull request
Oct 11, 2025
This reverts commit 2c574b9 because python311Packages.tkinter was fixed in NixOS#442184.
13 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hydra: https://hydra.nixos.org/build/306708195/nixlog/16
Failure probably introduced by #433833
x86_64-linux)cc @mweinelt
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.