Release PHPCompatibility 9.3.3 #926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced in 751 / 9.1.0. While interfaces can declare methods with the same name as the interface, as the class in which the method will be implemented will be called differently, those methods will never be seen as constructors, so shouldn't trigger this error. Mea culpa. Related: squizlabs/PHP_CodeSniffer 2663
Looking at the PHP source code, it appears these have been in PHP since 7.2.0, but are not documented in the PHP manual. Ref: * https://github.com/php/php-src/blob/master/ext/sodium/libsodium.c
ForbiddenNames: Add missing reserved keywords to ForbiddenNames sniff
…ore-sodium-constants NewConstants: account for yet more undocumented Sodium constants
…s-should-not-apply-to-interfaces RemovedPHP4StyleConstructors: should not apply to interfaces
Includes adding some missing "Fixes" to the 9.3.2 changelog. (already fixed up in the tag description)
Changelog for PHPCompatibility 9.3.3
wimg
approved these changes
Nov 10, 2019
Member
Author
|
Release tweet: https://twitter.com/jrf_nl/status/1193738941700214787 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for tracking changes for the 9.3.3 release. Target release date: Monday November 11.
master(careful, GH defaults todevelop!) & copy & paste the changelog to itOpen PR to mergemasterintodevelopto get rid of the This branch is out-of-date with the base branch messages on each release. (only after major releases)