🌐 AI搜索 & 代理 主页
Skip to content

Conversation

@jrfnl
Copy link
Member

@jrfnl jrfnl commented Nov 14, 2019

⚠️ DO NOT MERGE (YET) ⚠️

PR for tracking changes for the 9.3.4 release. Target release date: Friday November 15.

  • Add changelog for 9.3.4 - PR Changelog for PHPCompatibility 9.3.4 #931
  • Merge this PR
  • Add release tag against master (careful, GH defaults to develop!) & copy & paste the changelog to it
  • Close the 9.3.4 milestone
  • Open a new milestone for the next release
  • If any open PRs which were milestoned for 9.3.4 do not make it into the release, update their milestone. (not applicable)
  • Tweet about the release.
  • Post about it in Slack. (WordPress #tide channel and any others people deem relevant)
  • Open PR to merge master into develop to get rid of the This branch is out-of-date with the base branch messages on each release. (only after major releases)

jrfnl and others added 3 commits November 11, 2019 14:49
The changes in PR 923 did not take `foreach ( ...as list() ) {}` into account.

Fixed now. Includes unit test.

Fixes 928
Closes 929
…bidden-names-as-list

ForbiddenNames: allow for `foreach( ... as list() ) {}`
Includes adding missing milestone links for the 9.3.3 release.
@jrfnl jrfnl added Type: meta Repo strategy/structure related PR: ready for review labels Nov 14, 2019
@jrfnl jrfnl added this to the 9.3.4 milestone Nov 14, 2019
@jrfnl jrfnl requested a review from wimg November 14, 2019 14:30
@jrfnl jrfnl merged commit 1f37659 into master Nov 15, 2019
@jrfnl
Copy link
Member Author

jrfnl commented Nov 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: meta Repo strategy/structure related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants