Add keybinds for skipping and rewinding specific time periods in the replay viewer #1069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the right and left arrow buttons as shortcuts to the replay viewer, which skip (or rewind) one second. This is useful because selecting specific timestamps on the timeline can be annoying for long timelines.
By using modifier keys, a shorter or longer duration can be used:
SHIFT: 1 tick
CTRL: 10 seconds
ALT: 30 seconds
Multiple modifiers can be combined to multiply their changes. For example:
CTRL + SHIFT -> 10 ticks (0.5 seconds)
CTRL + ALT -> 300 seconds (5 minutes)
Do I just make a PR to the translations repo for the two translations I added? If so, should I translate them to my native language (German) immediately?