Make console commands lazy #11657
Merged
Make console commands lazy #11657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
approved these changes
Jul 17, 2020
Contributor
lchrusciel
left a comment
There was a problem hiding this comment.
Hey Eugene,
thanks for your proposal. Seems totally reasonable. Welcome to our community and my congratulation for your first PR ;)
Contributor
|
Thank you, Eugene! 🎉 |
Contributor
Author
|
Thank you too, for the great project! Glad to be helpful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is about of a little optimisation to avoid initialisation of all command services on each executing
bin/consolecommand.Since Symfony 3.4 console commands can be lazy thanks to a static name property.
This change does not break BC because the BC layer is already in the base command's constructor.