🌐 AI搜索 & 代理 主页
Skip to content

algorithm: first unique char in a string #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raklaptudirm merged 4 commits into from
Sep 22, 2022
Merged

algorithm: first unique char in a string #1103

raklaptudirm merged 4 commits into from
Sep 22, 2022

Conversation

@10kartik
Copy link
Contributor

@10kartik 10kartik commented Sep 19, 2022

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

appgurueu
appgurueu reviewed Sep 19, 2022
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently quadratic time (lastIndexOf and indexOf are linear time). Consider using a dict of chars to make this constant time.

@10kartik 10kartik requested a review from appgurueu September 19, 2022 18:19
@10kartik
Copy link
Contributor Author

10kartik commented Sep 19, 2022 •
edited
Loading

This is currently quadratic time (lastIndexOf and indexOf are linear time). Consider using a dict of chars to make this constant time.

dict or map either should work I guess, Looks good now?

appgurueu
appgurueu reviewed Sep 19, 2022
View reviewed changes
@10kartik 10kartik requested a review from appgurueu September 19, 2022 18:52
@raklaptudirm raklaptudirm changed the title feat: Added Algorithm first unique char in a string. algorithm: first unique char in a string Sep 22, 2022
@raklaptudirm raklaptudirm merged commit d05bbf7 into TheAlgorithms:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@10kartik @appgurueu @raklaptudirm