New commons, ESM-compatible Cypress integration #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make cypress integration compatible with both cjs and esm modules move some common utilities from node to framework directory change commons build workflow use absolute imports instead of relative ones in cypress tests use new commons for cypress integration
99362b5 to
ab980cf
Compare
just-boris
reviewed
Mar 19, 2024
Contributor
just-boris
left a comment
There was a problem hiding this comment.
Skimmed through the PR, looks good, nice modernization
just-boris
approved these changes
Mar 19, 2024
af2e146 to
2be1512
Compare
baev
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
new version of #897
Checklist