refactor(devtools): move route parsing logic to debug apis #65921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we depended on Angular DevTools specific logic to parse the underlying router tree from a router instance. Now, Angular DevTools defers this logic to the framework, so that we can change implementation on the across framework versions as needed, and make way for similar debug APIs in Wiz. There are test cases for the legacy implementation on the DevTools side and test cases for the framework implementation on the framework side.
JeanMeche
reviewed
Dec 9, 2025
| ): Route[] { | ||
| return children.map((child: AngularRoute) => { | ||
| const childName = childRouteName(child); | ||
| const loadedRoutes = (window as any).ng?.ɵgetLoadedRoutes?.(child as any); |
Member
There was a problem hiding this comment.
we should rely on ngDebugClient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we depended on Angular DevTools specific logic to parse the underlying router tree from a router instance.
Now, Angular DevTools defers this logic to the framework, so that we can change implementation on the across framework versions as needed, and make way for similar debug APIs in Wiz.
There are test cases for the legacy implementation on the DevTools side and test cases for the framework implementation on the framework side.