feat(docs-infra):Extracts aliases from doc entries #65936
+217
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29308d5 to
2b08496
Compare
2b08496 to
c22af99
Compare
Member
|
I think instead of relying on some extra jsdoc tags, we can be a bit smarter and extract them from the selector directly eg:
|
c22af99 to
46e54a0
Compare
JeanMeche
reviewed
Dec 10, 2025
| * @param selector The CSS selector string from directive/component metadata | ||
| * @returns Array of attribute names that can be used as aliases | ||
| */ | ||
| function extractAliasesFromSelector(selector: string): string[] { |
Member
There was a problem hiding this comment.
Can you please add some test coverage for this.
The extractor tests are located at packages/compiler-cli/test/ngtsc/doc_extraction
|
Deployed adev-preview for 46e54a0 to: https://ng-dev-previews-fw--pr-angular-angular-65936-adev-prev-bpbj4xc1.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
Implements a mechanism to extract alias names from a directive/component's selector.
46e54a0 to
4d9ea6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a mechanism to extract alias names from a directive/component's selector.
The implementation started in #65571 is now complete, enabling the addition of aliases for Angular Aria and allowing automatic generation of links for entries such as
ngToolbar.Then the output of entries should look something like this:
{ "...", "entries": [ { "...", "aliases": ["ngToolbar"] } ] }