refactor(core): Add ngDevMode guards and new sanitization error codes
#66015
+23
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngDevMode for tree-shaking in sanitizationngDevMode for tree-shaking in sanitization
202bd13 to
7350af6
Compare
JeanMeche
reviewed
Dec 11, 2025
| do { | ||
| if (mXSSAttempts === 0) { | ||
| throw new Error('Failed to sanitize html because the input is unstable'); | ||
| throw new Error( |
Member
There was a problem hiding this comment.
Those should be converted to RuntimeError. And error message without message nor code really isn't actionnable in a prod bundle.
7350af6 to
e1ccc0a
Compare
ngDevMode for tree-shaking in sanitizationngDevMode guards and new sanitization error codes
e1ccc0a to
1508cf5
Compare
JeanMeche
reviewed
Dec 12, 2025
Adds new runtime sanitization error codes. Adds `ngDevMode` guards around error message strings to ensure detailed diagnostics are included only in development mode. This allows production builds to tree-shake verbose error descriptions, reducing bundle size.
1508cf5 to
1d143a8
Compare
JeanMeche
approved these changes
Dec 12, 2025
Member
JeanMeche
left a comment
There was a problem hiding this comment.
reviewed-for: public-api, core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new runtime sanitization error codes. Adds
ngDevModeguards arounderror message strings to ensure detailed diagnostics are included only
in development mode. This allows production builds to tree-shake
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information