-
Notifications
You must be signed in to change notification settings - Fork 876
[Supervised AqlValue] Make functions use supervised AqlValue #22106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/supervised-aql-value
Are you sure you want to change the base?
Changes from 5 commits
4695ddc
8bf38cf
b3f570c
f4c98a3
7c96a1c
ac12386
a80de9d
4b44e5a
6132af1
349c88d
a21a067
98875a2
69bf641
f725133
bf3392e
2c5d770
0c9e57a
d5c571e
f62f392
1617e38
2f49ac3
7692c69
42855b2
5e0b8f4
a5ceec2
d12b34d
371dc5b
aecb218
b0b9ac7
34bb289
4b58613
3eef984
720ee57
bfc9715
ac2c304
7ea92bf
0f42608
1fe66cb
d7e9d31
049fe01
8cad3f7
8ad3a1f
6e64bde
8222211
788a006
a464c41
7c01568
9e56a4f
16d876f
c6d2c9d
3ec2380
cdcb261
2812ca4
c76d91f
22afa88
653a0a4
f48b51d
77d334e
9baaf97
7fe5b98
2e7fad9
a568a4c
93aa007
03990ca
fea5260
fe5df62
d6f55ac
a3f7c23
a072225
b0e8451
6701294
aeb2cd2
46a6094
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -476,7 +476,8 @@ AqlValue functions::Min(ExpressionContext* expressionContext, AstNode const&, | |
| if (minValue.isNone()) { | ||
| return AqlValue(AqlValueHintNull()); | ||
| } | ||
| return AqlValue(minValue); | ||
| ResourceMonitor* rm = expressionContext->getResourceMonitorPtr(); | ||
| return AqlValue(minValue, 0, rm); | ||
|
||
| } | ||
|
|
||
| /// @brief function MAX | ||
|
|
@@ -507,7 +508,8 @@ AqlValue functions::Max(ExpressionContext* expressionContext, AstNode const&, | |
| if (maxValue.isNone()) { | ||
| return AqlValue(AqlValueHintNull()); | ||
| } | ||
| return AqlValue(maxValue); | ||
| ResourceMonitor* rm = expressionContext->getResourceMonitorPtr(); | ||
| return AqlValue(maxValue, 0, rm); | ||
| } | ||
|
|
||
| /// @brief function SUM | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,6 +52,7 @@ | |
| #include <span> | ||
| #include <string_view> | ||
| #include <type_traits> | ||
| #include <immer/detail/combine_standard_layout.hpp> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Accidentally included unrelated immer internal headerThe |
||
|
|
||
| namespace { | ||
| // name of bind parameter variable that contains the current document | ||
|
|
@@ -147,7 +148,8 @@ aql::AqlValue ComputedValuesExpressionContext::getVariableValue( | |
| return aql::AqlValue(aql::AqlValueHintNull()); | ||
| } | ||
| if (doCopy) { | ||
| return aql::AqlValue(aql::AqlValueHintSliceCopy(it->second)); | ||
| return aql::AqlValue(aql::AqlValueHintSliceCopy(it->second), | ||
| getResourceMonitorPtr()); | ||
| } | ||
| return aql::AqlValue(aql::AqlValueHintSliceNoCopy(it->second)); | ||
| } | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.