[COR-50] Remove leasers from transaction context #22184
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6db4315 to
cdcf639
Compare
58fa312 to
020c3e5
Compare
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on December 28. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
markuspf
commented
Dec 11, 2025
a4e360a to
46a60a2
Compare
020c3e5 to
0ec747e
Compare
mpoeter
approved these changes
Dec 12, 2025
Comment on lines
-84
to
-89
| /// @brief temporarily lease a Builder object | ||
| TEST_VIRTUAL arangodb::velocypack::Builder* leaseBuilder(); | ||
|
|
||
| /// @brief return a temporary Builder object | ||
| TEST_VIRTUAL void returnBuilder(arangodb::velocypack::Builder*) noexcept; | ||
|
|
Contributor
There was a problem hiding this comment.
We should also remove the _builders member.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
As a followup to #22176 we can now remove all leasing functionality from the transaction context.
Merge #22176 first.