-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(table): add sticky header support (closes #2085) #3831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds in support for sticky table headers (with graceful fallback for IE11)
Codecov Report
@@ Coverage Diff @@
## dev #3831 +/- ##
========================================
+ Coverage 99.3% 99.3% +<.01%
========================================
Files 233 233
Lines 4433 4440 +7
Branches 1257 1262 +5
========================================
+ Hits 4402 4409 +7
Misses 25 25
Partials 6 6
Continue to review full report at Codecov.
|
19 tasks
jacobmllr95
approved these changes
Aug 8, 2019
jacobmllr95
reviewed
Aug 8, 2019
jacobmllr95
reviewed
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Adds in support for sticky table headers (with graceful fallback for IE11)
New prop
sticky-header, when set to true enables headers that remain sticky when table is scrolled. Default max-height is set to 300px in CSS, but users can optionally setsticky-headerto a string that specifies themax-height.Supported on
b-table,b-table-liteandb-table-simpleCloses #2085
Closes #555
Related upstream issue regarding table background-color inheritance: twbs/bootstrap#29244
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch, not themasterbranch[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)fix(alert): not alerting during SSR render,docs(badge): update pill examples, fix typos,chore: fix typo in README, etc). This is very important, as theCHANGELOGis generated from these messages.If new features/enhancement/fixes are added or changed:
package.jsonfor slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: