🌐 AI搜索 & 代理 主页
Skip to content

fix(tooltip, popover): hide trigger element title attribute during show delay (fixes #4114) #4120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmorehouse merged 7 commits into from
Sep 18, 2019
Merged

fix(tooltip, popover): hide trigger element title attribute during show delay (fixes #4114) #4120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0ebe249
fix(tooltip, popover): hide trigger element title attribute during en…
tmorehouse Sep 17, 2019
4377bcd
Update bv-tooltip.js
tmorehouse Sep 17, 2019
769ce1e
Update README.md
tmorehouse Sep 17, 2019
dcd0cb7
Update README.md
tmorehouse Sep 17, 2019
17154b0
Update README.md
tmorehouse Sep 17, 2019
a198a12
Merge branch 'dev' into issue/4114
tmorehouse Sep 18, 2019
f0a9445
Merge branch 'dev' into issue/4114
tmorehouse Sep 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/components/tooltip/helpers/bv-tooltip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,8 @@ export const BVTooltip = /*#__PURE__*/ Vue.extend({
// Hide the tooltip
const tip = this.getTemplateElement()
if (!tip || !this.localShow) {
/* istanbul ignore next */
this.restoreTitle()
/* istanbul ignore next */
return
}
Expand Down Expand Up @@ -613,7 +615,7 @@ export const BVTooltip = /*#__PURE__*/ Vue.extend({
const target = this.getTarget()
if (target && hasAttr(target, 'data-original-title')) {
setAttr(target, 'title', getAttr(target, 'data-original-title') || '')
setAttr(target, 'data-original-title', '')
removeAttr(target, 'data-original-title')
}
},
//
Expand Down Expand Up @@ -886,9 +888,14 @@ export const BVTooltip = /*#__PURE__*/ Vue.extend({
if (!this.computedDelay.show) {
this.show()
} else {
// Hide any title attribute while enter delay is active
this.fixTitle()
this.hoverTimeout = setTimeout(() => {
/* istanbul ignore else */
if (this.$_hoverState === 'in') {
this.show()
} else if (!this.localShow) {
this.restoreTitle()
}
}, this.computedDelay.show)
}
Expand Down
6 changes: 3 additions & 3 deletions src/directives/popover/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,11 +446,11 @@ Where `[mod]` can be (all optional):
- `nofade` to turn off animation.
- `html` to enable rendering raw HTML. by default HTML is escaped and converted to text.
- A delay value in the format of `d###` (where `###` is in ms, defaults to `50`), applied to both
`hide` and `show` (affects `hover` and `focus` only)
`hide` and `show`.
- A show delay value in the format of `ds###` (where `###` is in ms, defaults to `50`), applied to
`show` trigger only (affects `hover` and `focus` only)
`show` trigger only.
- A hide delay value in the format of `dh###` (where `###` is in ms, defaults to `50`), applied to
`hide` trigger only (affects `hover` and `focus` only)
`hide` trigger only.
- An offset value in pixels in the format of `o###` (where `###` is the number of pixels, defaults
to `0`. Negative values are allowed). Note if an offset is supplied, then the alignment positions
will fallback to one of `top`, `bottom`, `left`, or `right`.
Expand Down
16 changes: 8 additions & 8 deletions src/directives/tooltip/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,24 +309,24 @@ Where `[modX]` can be (all optional):

- Positioning: `top`, `bottom`, `left`, `right`, `auto`, `topleft`, `topright`, `bottomleft`,
`bottomright`, `lefttop`, `leftbottom`, `righttop`, or `rightbottom` (last one found wins,
defaults to `top`)
defaults to `top`).
- Event trigger: `click`, `hover`, `focus`, `blur` (if none specified, defaults to `focus` and
`hover`. `blur` is a close handler only, and if specified by itself, will be converted to
`focus`). Use `manual` if you only want to control the visibility manually.
- `nofade` to turn off animation
- `nofade` to turn off animation.
- `html` to enable rendering raw HTML. By default HTML is escaped and converted to text
- A delay value in the format of `d###` (where `###` is in ms, defaults to `50`), applied to both
`hide` and `show` (affects `hover` and `focus` only)
`hide` and `show`.
- A show delay value in the format of `ds###` (where `###` is in ms, defaults to `50`), applied to
`show` trigger only (affects `hover` and `focus` only)
`show` trigger only.
- A hide delay value in the format of `dh###` (where `###` is in ms, defaults to `50`), applied to
`hide` trigger only (affects `hover` and `focus` only)
`hide` trigger only.
- An offset value in pixels in the format of `o###` (where `###` is the number of pixels, defaults
to `0`. Negative values allowed)
to `0`. Negative values allowed).
- A boundary setting of `window` or `viewport`. The element to constrain the visual placement of the
tooltip. If not specified, the boundary defaults to the trigger element's scroll parent (in most
cases this will suffice)
- A contextual variant in the form of `v-XXX` (where `XXX` is the color variant name)
cases this will suffice).
- A contextual variant in the form of `v-XXX` (where `XXX` is the color variant name).

Where `<value>` can be (optional):

Expand Down