🌐 AI搜索 & 代理 主页
Skip to content

feat(b-table): default the row select feature selected-variant to the active variant #4128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmorehouse merged 16 commits into from
Oct 14, 2019
Merged

feat(b-table): default the row select feature selected-variant to the active variant #4128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d75c521
feat(b-table): default row select feature `selected-variant` to `active`
tmorehouse Sep 19, 2019
c1bf62b
Merge branch 'dev' into tmorehouse/table-active-default
tmorehouse Sep 19, 2019
8c61180
Merge branch 'dev' into tmorehouse/table-active-default
jacobmllr95 Sep 21, 2019
1b97fcc
Merge branch 'dev' into tmorehouse/table-active-default
tmorehouse Sep 26, 2019
cfbd6df
Merge branch 'dev' into tmorehouse/table-active-default
tmorehouse Oct 2, 2019
2d2a480
Merge branch 'dev' into tmorehouse/table-active-default
tmorehouse Oct 3, 2019
98f7cb5
Merge branch 'dev' into tmorehouse/table-active-default
tmorehouse Oct 6, 2019
8e62a73
Merge branch 'dev' into tmorehouse/table-active-default
tmorehouse Oct 11, 2019
2cec805
Update README.md
tmorehouse Oct 11, 2019
8007125
Update package.json
tmorehouse Oct 11, 2019
f472289
Merge branch 'dev' into tmorehouse/table-active-default
tmorehouse Oct 11, 2019
2962fbb
Update README.md
jacobmllr95 Oct 14, 2019
d84bb4e
Merge branch 'dev' into tmorehouse/table-active-default
jacobmllr95 Oct 14, 2019
fc36e3d
Merge branch 'dev' into tmorehouse/table-active-default
tmorehouse Oct 14, 2019
646fdee
Update README.md
tmorehouse Oct 14, 2019
0233140
Update package.json
tmorehouse Oct 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/components/table/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1541,12 +1541,12 @@ example).

The `selected-variant` can be any of the
[standard (or custom) bootstrap base color variants](/docs/reference/color-variants), or the special
[table `active` variant](/docs/reference/color-variants#table-variants) which takes precedence over
any specific row or cell variants.
[table `active` variant](/docs/reference/color-variants#table-variants) (the default) which takes
precedence over any specific row or cell variants.

For accessibility reasons (specifically for color blind users, or users with color contrast issues),
it is highly recommended to always provide some other visual means of conveying that a row is
selected, such as shown in the example below.
selected, such as a virtual column as shown in the example below.

```html
<template>
Expand All @@ -1559,7 +1559,6 @@ selected, such as shown in the example below.
ref="selectableTable"
selectable
:select-mode="selectMode"
selected-variant="active"
:items="items"
:fields="fields"
@row-selected="onRowSelected"
Expand Down
2 changes: 1 addition & 1 deletion src/components/table/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@
},
{
"prop": "selectedVariant",
"description": "Bootstrap color theme variant to set selected rows to. use any of hte standard Bootstrap theme variants, or the special table row variant 'active'"
"description": "Bootstrap color theme variant to set selected rows to. Use any of the standard Bootstrap theme color variants, or the special table row variant 'active' (default). Set to an empty string to not use a variant"
},
{
"prop": "showEmpty",
Expand Down
2 changes: 1 addition & 1 deletion src/utils/config-defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ export default deepFreeze({
variant: null
},
BTable: {
selectedVariant: 'primary',
selectedVariant: 'active',
headVariant: null,
footVariant: null
},
Expand Down