feat(chore): configure pre-commit hook (fixes #4532) #4552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #4552 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 251 251
Lines 5218 5218
Branches 1380 1380
=======================================
Hits 5214 5214
Misses 3 3
Partials 1 1Continue to review full report at Codecov.
|
jacobmllr95
approved these changes
Jan 3, 2020
Member
|
Thanks @jamesgeorge007! |
This was referenced Jan 17, 2020
This was referenced Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
closes #4532
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
It's submitted to the
devbranch, not themasterbranchWhen resolving a specific issue, it's referenced in the PR's title (i.e.
[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
The title should follow the Conventional Commits naming convention (i.e.
fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc). This is very important, as theCHANGELOGis generated from these messages.Includes documentation updates (including updating the component's
package.jsonfor slot and event changes)Includes any needed TypeScript declaration file updates
New/updated tests are included and passing (if required)
Existing test suites are passing
CodeCov for patch has met target
The changes have not impacted the functionality of other components or directives
ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)