🌐 AI搜索 & 代理 主页
Skip to content

Conversation

@tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Feb 15, 2020

Describe the PR

Removes unused hoverswap private component in favour of the new v-b-hover directive (PR #4771)

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe) refactor

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse changed the title chore: delete hoverswap private util in favor of v-b-hover directive chore: delete hoverswap private util component in favor of v-b-hover directive Feb 15, 2020
@tmorehouse tmorehouse marked this pull request as ready for review February 15, 2020 05:50
@codecov
Copy link

codecov bot commented Feb 15, 2020

Codecov Report

Merging #4772 into feat/v-b-hover will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           feat/v-b-hover    #4772      +/-   ##
==================================================
- Coverage           99.92%   99.92%   -0.01%     
==================================================
  Files                 257      256       -1     
  Lines                5300     5282      -18     
  Branches             1407     1402       -5     
==================================================
- Hits                 5296     5278      -18     
  Misses                  3        3              
  Partials                1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc86219...cd38824. Read the comment docs.

@tmorehouse tmorehouse added the PR: Patch Requires patch version bump label Feb 15, 2020
@jacobmllr95 jacobmllr95 merged commit f0be2d1 into feat/v-b-hover Feb 15, 2020
@jacobmllr95 jacobmllr95 deleted the delete/hover-swap branch February 15, 2020 07:08
@tmorehouse tmorehouse restored the delete/hover-swap branch February 15, 2020 07:18
@tmorehouse tmorehouse deleted the delete/hover-swap branch February 15, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Patch Requires patch version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants