🌐 AI搜索 & 代理 主页
Skip to content

fix(b-modal): additional fixes for show transition behaviour (closes #4761) #4777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmorehouse merged 3 commits into from
Feb 17, 2020
Merged

fix(b-modal): additional fixes for show transition behaviour (closes #4761) #4777

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27b8c7b
fix(b-modal): inconsistent show transition behaviour
philipmountifield Feb 17, 2020
7dcc0a2
Update modal.js
jacobmllr95 Feb 17, 2020
ba56530
Merge branch 'dev' into issue/4761
tmorehouse Feb 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/components/modal/modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,9 +604,13 @@ export const BModal = /*#__PURE__*/ Vue.extend({
},
onEnter() {
this.isBlock = true
// We add show class 1 frame after
// We add the `show` class 1 frame later
// `requestAF()` runs the callback before the next repaint, so we need
// two calls to guarantee the next frame has been rendered
requestAF(() => {
this.isShow = true
requestAF(() => {
this.isShow = true
})
})
},
onAfterEnter() {
Expand Down