🌐 AI搜索 & 代理 主页
Skip to content

fix(b-form-spinbutton): respect step value for initial decrement when wrap enabled (closes #4884) #4885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacobmllr95 merged 4 commits into from
Mar 5, 2020
Merged

fix(b-form-spinbutton): respect step value for initial decrement when wrap enabled (closes #4884) #4885

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d6464e
fix(b-form-spinbutton): respect step value when decrementing (closes …
tmorehouse Mar 5, 2020
0e813c2
Update form-spinbutton.js
tmorehouse Mar 5, 2020
c5acf96
Merge branch 'dev' into spinbutton-step
tmorehouse Mar 5, 2020
0f11aa6
Merge branch 'dev' into spinbutton-step
jacobmllr95 Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/form-spinbutton/form-spinbutton.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,11 @@ export const BFormSpinbutton = /*#__PURE__*/ Vue.extend({
return defaultNumber(this.min, DEFAULT_MIN)
},
computedMax() {
return defaultNumber(this.max, DEFAULT_MAX)
// We round down to the nearest maximum step value
const max = defaultNumber(this.max, DEFAULT_MAX)
const step = this.computedStep
const min = this.computedMin
return Math.floor((max - min) / step) * step + min
},
computedDelay() {
return defaultInteger(this.repeatDelay, DEFAULT_REPEAT_DELAY) || DEFAULT_REPEAT_DELAY
Expand Down