🌐 AI搜索 & 代理 主页
Skip to content

Conversation

@jacobmllr95
Copy link
Member

@jacobmllr95 jacobmllr95 commented May 11, 2020

Describe the PR

This PR adds the following new DOM utils for focus and blur handling:

  • getActiveElement() - Get the currently active HTML element
  • isActiveElement() - Determine if an HTML element is the currently active element
  • attemptFocus() - Attempt to focus an element
  • attemptBlur() - Attempt to blur an element

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) - fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) - feat(...), requires a minor version update
  • Enhancement (augments an existing feature) - feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) - fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) - chore(docs), requires a patch version update
  • Other (please describe) Code refactor

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@vercel
Copy link

vercel bot commented May 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/k2rrzsuma
✅ Preview: https://bootstrap-vue-git-feat-new-dom-utils.bootstrap-vue.now.sh

@jacobmllr95
Copy link
Member Author

@tmorehouse I'am running into the TypeError stuff in the tests agin for document.activeElement. Can you take a look at it?

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 11, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5314d41:

Sandbox Source
elated-sun-wh6f0 Configuration

@tmorehouse tmorehouse changed the title feat(utils/dom): add new utils for focus/blur handling chore(utils/dom): add new utils for focus/blur handling May 11, 2020
@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #5346 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #5346   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          281       281           
  Lines         8862      8825   -37     
  Branches      2510      2505    -5     
=========================================
- Hits          8862      8825   -37     
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)
Impacted Files Coverage Δ
src/components/carousel/carousel.js 100.00% <ø> (ø)
src/components/button-toolbar/button-toolbar.js 100.00% <100.00%> (ø)
src/components/calendar/calendar.js 100.00% <100.00%> (ø)
src/components/form-datepicker/form-datepicker.js 100.00% <100.00%> (ø)
src/components/form-group/form-group.js 100.00% <100.00%> (ø)
src/components/form-input/form-input.js 100.00% <100.00%> (ø)
src/components/form-rating/form-rating.js 100.00% <100.00%> (ø)
src/components/form-select/form-select.js 100.00% <100.00%> (ø)
src/components/form-spinbutton/form-spinbutton.js 100.00% <100.00%> (ø)
src/components/form-tags/form-tags.js 100.00% <100.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e1e394...5314d41. Read the comment docs.

@jacobmllr95 jacobmllr95 marked this pull request as ready for review May 11, 2020 17:15
@jacobmllr95 jacobmllr95 requested a review from tmorehouse May 11, 2020 17:17
@jacobmllr95 jacobmllr95 merged commit 0009784 into dev May 11, 2020
@jacobmllr95 jacobmllr95 deleted the feat-new-dom-utils branch May 11, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Patch Requires patch version bump Type: Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants