refactor: select and unselect row methods in BTable #2875

VividLemon · 2025-10-09T14:44:13Z

Describe the PR

A clear and concise description of what the pull request does.

Small replication

A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.

PR checklist

What kind of change does this PR introduce? (check at least one)

The PR fulfills these requirements:

Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

Summary by CodeRabbit

Refactor
- Streamlined internal slot bindings in the table component to use scoped indices directly, reducing indirection and improving maintainability.
- No changes to public APIs: props, slots, and emitted events remain the same.
- Fully backward-compatible; existing integrations continue to work without modification.
- No visual or behavioral differences in row selection, unselection, or row-details rendering.
- No action required for users.

bolt-new-by-stackblitz · 2025-10-09T15:25:55Z

Run & review this pull request in StackBlitz Codeflow.

coderabbitai · 2025-10-09T15:29:16Z

Walkthrough

Refactors slot bindings in BTable.vue to use scope.index directly instead of passing an index parameter for row-details and dynamic cell slots. The change replaces parameterized functions with zero-argument functions that reference scope.index. No public APIs, events, or behavior are altered.

Changes

Cohort / File(s)	Summary
BTable slot binding refactor `packages/bootstrap-vue-next/src/components/BTable/BTable.vue`	Replaced index-parameter functions with zero-arg callbacks that read `scope.index` for :select-row and :unselect-row in row-details and dynamic cell slots; logic and emissions unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nibble through slots with careful cheer,
Pluck index from scope, keep intent clear.
No ripples in rows, no columns askew—
Just quieter code, a tidier view.
Thump goes my paw: refactor, done—woo! 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The pull request description consists solely of the unmodified template sections with placeholder text and lacks any actual explanation of the changes, missing a filled-out description, replication details, and a completed checklist.	Please update the description by providing a clear summary of the refactoring, include any replication steps or examples if available, and complete the PR checklist with the appropriate change type and confirmation of Conventional Commit compliance.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The pull request title clearly and concisely summarizes the primary change by indicating it refactors the select and unselect row methods in BTable, which matches the modifications in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch VividLemon-patch-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/bootstrap-vue-next/src/components/BTable/BTable.vue (1)

28-29: Document the slot prop signature change. The selectRow and unselectRow slot props no longer accept an index argument (they now close over scope.index). No consumer code was found passing explicit indices, but please add a note about this breaking change in the changelog or PR description.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6828a1b and 3ac5edd.

📒 Files selected for processing (1)

packages/bootstrap-vue-next/src/components/BTable/BTable.vue (2 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

packages/bootstrap-vue-next/src/components/**

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Create and modify Vue components only under packages/bootstrap-vue-next/src/components/

Files:

packages/bootstrap-vue-next/src/components/BTable/BTable.vue

packages/bootstrap-vue-next/src/components/**/*.vue

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Keep component-specific styles within their respective .vue single-file components

Files:

packages/bootstrap-vue-next/src/components/BTable/BTable.vue

🔇 Additional comments (1)

packages/bootstrap-vue-next/src/components/BTable/BTable.vue (1)

46-47: Consistent refactor applied to dynamic cell slots.

The same zero-argument function pattern is correctly applied here for dynamic cell slots, maintaining consistency with the row-details slot changes. The implementation is sound.

Note: The API change concern mentioned in the previous comment (lines 28-29) applies equally here.

pkg-pr-new · 2025-10-09T15:37:35Z

bsvn-vite-ts

npm i https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next@2875

npm i https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next/@bootstrap-vue-next/nuxt@2875

commit: 3ac5edd

refactor: select and unselect row methods in BTable

3ac5edd

coderabbitai bot reviewed Oct 9, 2025

View reviewed changes

VividLemon merged commit 8d9cc88 into main Oct 22, 2025
5 checks passed

coderabbitai bot mentioned this pull request Nov 18, 2025

refactor(BTable): move code into composables for better sorting #2913

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor: select and unselect row methods in BTable #2875

refactor: select and unselect row methods in BTable #2875

Uh oh!

VividLemon commented Oct 9, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

bolt-new-by-stackblitz bot commented Oct 9, 2025

Uh oh!

coderabbitai bot commented Oct 9, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

pkg-pr-new bot commented Oct 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

refactor: select and unselect row methods in BTable #2875

refactor: select and unselect row methods in BTable #2875

Uh oh!

Conversation

VividLemon commented Oct 9, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe the PR

Small replication

PR checklist

Summary by CodeRabbit

Uh oh!

bolt-new-by-stackblitz bot commented Oct 9, 2025

Uh oh!

coderabbitai bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new bot commented Oct 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

VividLemon commented Oct 9, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 9, 2025 •

edited

Loading