Updated composer.json and readme to include composer. #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlbooker
reviewed
Nov 1, 2018
Contributor
|
Today I Learned that this project has a composer.json. As far as I know it's not registered with packagist, though. I'm not sure there's a huge use-case for doing so, since there's zero lines of PHP in the project, but I'm not opposed to registering it if people are interested. I think if you fix that one URL to bloodhound.js in readme.md, I should be able to merge this without issue. |
Contributor
Author
|
Yeah, it’s worth it.
Composer originally was for php dependencies, but it’s grown to include almost everything.
It’s become almost like an apt/yum catchall for project dependencies for anything needed for a php website project.
|
devcorrelator
commented
Nov 1, 2018
Contributor
Author
devcorrelator
left a comment
There was a problem hiding this comment.
Fixed issue with the bloodhound link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this package is registered with packagist correctly, but the composer.json should be updated if you want to register it.