🌐 AI搜索 & 代理 主页
Skip to content

More robust Limited API SetItemOnTypeDict #6325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scoder merged 7 commits into from
Aug 5, 2024
Merged

More robust Limited API SetItemOnTypeDict #6325

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6eb2278
More robust Limited API SetItemOnTypeDict
da-woods Aug 4, 2024
e2f6205
Error handling + fix DelItem
da-woods Aug 4, 2024
de025f5
unlikely
da-woods Aug 4, 2024
2be97fc
typo
da-woods Aug 4, 2024
f6b96a9
Move caching out a layer
da-woods Aug 4, 2024
eb291a9
Move error handling outside of normal execution path.
scoder Aug 5, 2024
7876f1c
Mark first lookup as "unlikely()".
scoder Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Mark first lookup as "unlikely()".
  • Loading branch information
@scoder
scoder authored Aug 5, 2024
commit 7876f1cae2664278f2a96b12e18c52eed41f87b2
2 changes: 1 addition & 1 deletion Cython/Utility/ExtensionTypes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,7 +729,7 @@ static PyObject *__Pyx_GetTypeDict(PyTypeObject *tp) {
// TODO - if we ever support custom metatypes for extension types then
// we have to modify this caching.
static Py_ssize_t tp_dictoffset = 0;
if (tp_dictoffset == 0) {
if (unlikely(tp_dictoffset == 0)) {
tp_dictoffset = __Pyx_GetTypeDictOffset();
// Note that negative dictoffsets are definitely allowed.
// A dictoffset of -1 seems unlikely but isn't obviously forbidden.
Expand Down