[dart2js] Correct comment #50752
[dart2js] Correct comment #50752
Conversation
| TokenScope scope = new TokenScope(initialChar: $A + 1); | ||
|
|
||
| // We start with 'A'. | ||
| // We start with 'B'. |
There was a problem hiding this comment.
Thank you for the contribution, but I think this comment is correct. We start with A so we naturally get B when we ask for the next name.
There was a problem hiding this comment.
I don't think so, line 78 starts with $A+1 which is $B
There was a problem hiding this comment.
To be slightly more explicit, if your explanation was correct, then the comment in the previous block would be wrong, but it really can't be:
sdk/pkg/compiler/test/model/token_naming_test.dart
Lines 69 to 72 in 94f20d7
There was a problem hiding this comment.
Fair point. It seems that getNextName actually returns the current name and advances. Makes sense.
|
+2ed the CL (https://dart-review.googlesource.com/c/sdk/+/275985), waiting for it to land. |
I have a much larger change that includes changes to this file, but I figure I'd start with this change.