🌐 AI搜索 & 代理 主页
Skip to content

Conversation

@selfisekai
Copy link
Contributor

part of #51535

subprocess.check_output returns bytes, not str

it doesn't seem to be used yet in the project, so I assume it doesn't work for anyone. not sure how did it land here if it doesn't work (returned type changed in python 3?)

subprocess.check_output returns bytes, not str
@copybara-service
Copy link

Thank you for your contribution. This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/286604

Please wait for a developer to review your code review at the above link. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. You can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code and they will help you. You can also push additional commits to this pull request to update the code review.

@copybara-service
Copy link

Thank you for your contribution. This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/286603

Please wait for a developer to review your code review at the above link. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. You can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code and they will help you. You can also push additional commits to this pull request to update the code review.

@sortie
Copy link
Contributor

sortie commented Mar 8, 2023

Thanks :)

Do add me as a reviewer if you're able to rather than merely a cc :)

If you're able to use gerrit and depot_tools, consider going through git cl upload directly instead of using pull requests since it's the proper workflow

@selfisekai
Copy link
Contributor Author

I got git-cl working after submitting these 2 PRs. should I also add you as reviewer on chromium changes? what if I can't submit changes on some repositories? (namely, chromium/src/third_party/zlib)

@sortie
Copy link
Contributor

sortie commented Mar 8, 2023

I don't own the chrome repositories so I can't review other there but feel free to cc me if I have an user account there.

@copybara-service copybara-service bot closed this in d9e8662 Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants