Update TYPO3 recipe and improve docs #4105
Merged
+121
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi David, i tested the changes. Now it's working fine. But there is something else missing: The TYPO3 recipe does not include the crucial task('deploy', [
'deploy:info',
'deploy:setup',
'deploy:lock',
'deploy:release',
'typo3:update_code',
'deploy:shared',
'deploy:writable',
'deploy:vendors',
'typo3:cache:warmup',
'typo3:extension:setup',
'typo3:language:update',
'typo3:cache:flush',
// MISSING deploy:symlink
'deploy:unlock',
'deploy:cleanup',
'deploy:success',
]);The least tasks can be replaced with // recipe/common.php
task('deploy:publish', [
'deploy:symlink',
'deploy:unlock',
'deploy:cleanup',
'deploy:success',
]); |
Contributor
|
Any update on this? |
MarcoRemy
suggested changes
Sep 9, 2025
Contributor
MarcoRemy
left a comment
There was a problem hiding this comment.
In recipe/typo3.php replace lines 216-218 with deploy:publish or put deploy:symlink before
antonmedv
approved these changes
Sep 10, 2025
Contributor
|
@antonmedv please merge this PR. I will create a fix for the missing task. |
antonmedv
approved these changes
Sep 17, 2025
Contributor
Author
|
Hey @MarcoRemy, thanks for jumping in, I was afk for a couple of weeks. Happy that this is complete now :) |
Member
|
Will release a new v8 beta soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bin/typo3path and improved documentationThis PR updates the TYPO3 Deployer recipe to standardize CLI calls using
{{bin/typo3}}instead of hard-coded paths, ensuring compatibility with custom composer settings. Also inline PHPDoc comments and a usage example at the top of the file were included to improve maintainability and make the deployment process clearer for future developers.