Fixed windowing example in expressions docs #20367
Open
+4
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
N/A
Branch description
In the section regarding window functions of the models/expressions docs, there's an example of querying for ratings of peer movies. Peers are described as follows:
The example uses the release year for ordering and doesn't partition by them, which results in a cumulative query where movies from all years up until the release year of the movie in question are included in the average. Fixed by partitioning by the release year instead of ordering by it.
minimal repro in-memory main.py:
output:
Checklist
mainbranch.