🌐 AI搜索 & 代理 主页
Skip to content

Remove deprecations using Symfony 6.4 #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GromNaN merged 7 commits into from
Dec 9, 2023
Merged

Remove deprecations using Symfony 6.4 #789

GromNaN merged 7 commits into from
Dec 9, 2023

Conversation

@franmomu
Copy link
Contributor

@franmomu franmomu commented Oct 29, 2023 •
edited
Loading

Because of symfony/symfony#50391 there are these deprecations:

1x: The "Doctrine\Bundle\MongoDBBundle\CacheWarmer\HydratorCacheWarmer::warmUp()" method will require a new "string|null $buildDir" argument in the next major version of its interface "Symfony\Component\HttpKernel\CacheWarmer\WarmableInterface", not defining it is deprecated.
    1x in HydratorCacheWarmerTest::setUp from Doctrine\Bundle\MongoDBBundle\Tests\CacheWarmer

  1x: The "Doctrine\Bundle\MongoDBBundle\CacheWarmer\PersistentCollectionCacheWarmer::warmUp()" method will require a new "string|null $buildDir" argument in the next major version of its interface "Symfony\Component\HttpKernel\CacheWarmer\WarmableInterface", not defining it is deprecated.
    1x in PersistentCollectionCacheWarmerTest::setUp from Doctrine\Bundle\MongoDBBundle\Tests\CacheWarmer

  1x: The "Doctrine\Bundle\MongoDBBundle\CacheWarmer\ProxyCacheWarmer::warmUp()" method will require a new "string|null $buildDir" argument in the next major version of its interface "Symfony\Component\HttpKernel\CacheWarmer\WarmableInterface", not defining it is deprecated.
    1x in ProxyCacheWarmerTest::setUp from Doctrine\Bundle\MongoDBBundle\Tests\CacheWarmer

I've created a second commit to silence these ones, but the changes are not BC, so we have to decide if we are fine with that or we should ignore it for now.

There are some other deprecations that we have to take a look.

@franmomu franmomu added the Task label Oct 29, 2023
@franmomu franmomu added this to the 4.6.3 milestone Oct 29, 2023
@franmomu franmomu force-pushed the test_with_symfony64 branch from 52b0c81 to 9d65757 Compare December 5, 2023 08:28
@franmomu franmomu changed the base branch from 4.6.x to 4.7.x December 5, 2023 08:28
@franmomu franmomu modified the milestones: 4.6.3, 4.7.0 Dec 5, 2023
@franmomu franmomu force-pushed the test_with_symfony64 branch from 9d65757 to b09c0e5 Compare December 5, 2023 08:37
@franmomu franmomu changed the title Test with symfony64 Remove deprecations using Symfony 6.4 Dec 5, 2023
@franmomu franmomu marked this pull request as ready for review December 5, 2023 08:51
GromNaN
GromNaN reviewed Dec 5, 2023
View reviewed changes
@franmomu
Copy link
Contributor Author

franmomu commented Dec 5, 2023

The BC break changes are mandatory if we want to have compatibility with Symfony 7, that's why I targeted 4.7.x, this PR would resolve some of the issues in #784

@franmomu franmomu requested review from alcaeus and malarzm December 8, 2023 15:03
@GromNaN GromNaN merged commit 8a31e71 into doctrine:4.7.x Dec 9, 2023
@GromNaN
Copy link
Member

GromNaN commented Dec 9, 2023

Thank you very much @franmomu

@franmomu franmomu deleted the test_with_symfony64 branch December 9, 2023 12:01
@franmomu franmomu mentioned this pull request Dec 9, 2023
Merged
@GromNaN GromNaN mentioned this pull request Dec 12, 2023
Closed
@github-actions github-actions bot mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GromNaN GromNaN GromNaN approved these changes

@alcaeus alcaeus Awaiting requested review from alcaeus

@malarzm malarzm Awaiting requested review from malarzm

Assignees

No one assigned

Labels

Task

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@franmomu @GromNaN