Bring back SYMFONY_TMP_DIR (in another form) for Docker optimization #543
Conversation
|
@Plopix maybe it also worth to add those variables in default |
|
I mean just two variables for cache and logs dirs? |
|
not sure about complexifying more the |
|
Hello @Plopix. I removed it because we don't want to do any changes to |
|
ok @webhdx symfony/symfony#37114 let's see |
|
it's going to be approved I guess but that would be for Symfony 5.2 anyway. It might make sense to anticipate in eZ for now on. (instead of waiting eZ 3.2 or even 3.3) |
…the ENV (Plopix) This PR was merged into the 5.2-dev branch. Discussion ---------- Provides a way to override cache and log folders from the ENV | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT When using Docker and especially on Mac OS X, performances are terrible when using a "mount" on the host inside the container. (which happens by default) To optimize the performances, one of the tricks is to change where the application is going to write the cache and the logs. This PR provides a new env variables `APP_CACHE_DIR` and `APP_LOG_DIR` which can be set to change where will be saved the caches and the logs. I know we can do it per project BUT: - I think that is a good addition to Symfony - it would allow project like eZ Platform and eZ Launchpad to automate that optimization ezsystems/ezplatform#543 Let me know Commits ------- 5fa5d36 Provides a way to override cache and log folders form the ENV
…the ENV (Plopix) This PR was merged into the 5.2-dev branch. Discussion ---------- Provides a way to override cache and log folders from the ENV | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT When using Docker and especially on Mac OS X, performances are terrible when using a "mount" on the host inside the container. (which happens by default) To optimize the performances, one of the tricks is to change where the application is going to write the cache and the logs. This PR provides a new env variables `APP_CACHE_DIR` and `APP_LOG_DIR` which can be set to change where will be saved the caches and the logs. I know we can do it per project BUT: - I think that is a good addition to Symfony - it would allow project like eZ Platform and eZ Launchpad to automate that optimization ezsystems/ezplatform#543 Let me know Commits ------- 5fa5d36153 Provides a way to override cache and log folders form the ENV
|
Please wait a bit before merge, maybe we need: symfony/symfony#37232 |
tomaszszopinski
left a comment
There was a problem hiding this comment.
QA approved on eZPlatform 3.1dev with diff.
|
@Plopix is anything holding us back to merge it? |
But also platform.sh
|
@mnocon could you merge it up and sideways? |
|
Thank you @Plopix 👍 |
There is a slack discussion in #ez-launchpad.
But I prefer to open that PR to the community.
Without this, there is no way to tell Docker to save the Symfony cache in the container rather than in the host.
On Mac OS this is a performance killer.
On 2.5 we still have it, why has it been removed?
https://github.com/ezsystems/ezplatform/blob/2.5/app/AppKernel.php#L84
Thanks!