Fix types: i18n component ‘tag’ prop can also be boolean ‘false’ #987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16ca6cb to
71377c1
Compare
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #987 +/- ##
=======================================
Coverage 98.60% 98.60%
=======================================
Files 12 12
Lines 215 215
Branches 46 46
=======================================
Hits 212 212
Misses 1 1
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Demivan
reviewed
Nov 21, 2025
0d6a85b to
c524cc6
Compare
Passing ‘:tag=false’ to the i18n component renders no tag, but TypeScript would complain, since the prop type was defined to allow only strings. Widen the type to also allow boolean ‘false’, which matches runtime behaviour and docs.
f92e7a4 to
254f7f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing ‘:tag=false’ to the i18n component renders no tag, but
TypeScript would complain, since the prop type was defined to allow
only strings.
Widen the type to also allow boolean ‘false’, which matches runtime
behaviour and docs.