C#: Remove PreSsa library
#20994
Open
C#: Remove PreSsa library
#20994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5fb90fb to
857b1d1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the PreSsa library from the C# codebase following the removal of CFG splitting based on Boolean values. The cleanup consolidates SSA-related functionality into the BaseSSA module.
- The entire
PreSsa.qlllibrary is deleted along with its associated test files - SSA functionality previously in
PreSsa(likeSimpleLocalScopeVariableand related predicates) is migrated toBaseSSA.qll - References to
PreSsaacross the codebase are updated to useBaseSSAinstead
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
csharp/ql/lib/semmle/code/csharp/controlflow/internal/PreSsa.qll |
Deleted - entire PreSsa library removed |
csharp/ql/test/library-tests/dataflow/ssa/PreSsaConsistency.ql |
Deleted - test file for PreSsa consistency checks |
csharp/ql/test/library-tests/dataflow/ssa/PreSsaConsistency.expected |
Deleted - expected output for PreSsa consistency tests |
csharp/ql/lib/semmle/code/csharp/dataflow/internal/BaseSSA.qll |
Moved SimpleLocalScopeVariable class and supporting predicates from PreSsa |
csharp/ql/lib/semmle/code/csharp/dataflow/internal/SsaImpl.qll |
Updated import from PreSsa to BaseSSA |
csharp/ql/lib/semmle/code/csharp/controlflow/internal/Splitting.qll |
Removed TSsaBooleanSplitSubKind and PreSsa import |
csharp/ql/lib/semmle/code/csharp/controlflow/Guards.qll |
Removed PreCfg module and moved predicates to top level; one incorrect reference updated |
csharp/ql/test/library-tests/dataflow/defuse/useUseEquivalence.ql |
Updated import and type references from PreSsa to BaseSSA |
csharp/ql/test/library-tests/dataflow/defuse/parameterUseEquivalence.ql |
Updated import and type references from PreSsa to BaseSSA |
csharp/ql/test/library-tests/dataflow/defuse/defUseEquivalence.ql |
Updated import and type references from PreSsa to BaseSSA |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7589533 to
adac392
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that CFG splitting based on Boolean values has been removed, we no longer need the
PreSsalibrary.