🌐 AI搜索 & 代理 主页
Skip to content

Rust: Fix some false positives for rust/unused-variable and rust/unused-value #21009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geoffw0 wants to merge 5 commits into
base: main
Choose a base branch
from
+10 −0
Open

Rust: Fix some false positives for rust/unused-variable and rust/unused-value #21009

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c160a1f
Rust: Fix common FPs for rust/unused-variable and rust/unused-value.
geoffw0 Dec 10, 2025
6ca90a2
Rust: Change note.
geoffw0 Dec 10, 2025
f1d241f
Rust: Accept test change.
geoffw0 Dec 10, 2025
d88bae9
Rust: Narrow the exclusion a little.
geoffw0 Dec 11, 2025
ee13a49
Merge branch 'main' into varfps
geoffw0 Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rust: Narrow the exclusion a little.
  • Loading branch information
@geoffw0
geoffw0 committed Dec 11, 2025
commit d88bae9ec20df5e18dba21f7e07db0c63724b11f
8 changes: 5 additions & 3 deletions rust/ql/src/queries/unusedentities/UnusedVariable.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ predicate isAllowableUnused(Variable v) {
// a 'self' variable
v.getText() = "self"
or
// a common source of false positives is match arms that are misrecognized as
// a variable, having not been correctly resolved
v.getPat().getParentNode() instanceof MatchArm
// a common source of false positives is match arms containing constants
// (typically beginning with a capital letter) that are misrecognized as a
// variable, having not been correctly resolved.
v.getPat().getParentNode() instanceof MatchArm and
v.getText().charAt(0).isUppercase()
}
1 change: 1 addition & 0 deletions rust/ql/test/query-tests/unusedentities/UnusedVariable.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
| main.rs:307:13:307:15 | num | Variable 'num' is not used. |
| main.rs:342:25:342:25 | y | Variable 'y' is not used. |
| main.rs:345:28:345:28 | a | Variable 'a' is not used. |
| main.rs:348:9:348:9 | p | Variable 'p' is not used. |
| main.rs:366:9:366:13 | right | Variable 'right' is not used. |
| main.rs:372:9:372:14 | right2 | Variable 'right2' is not used. |
| main.rs:383:13:383:13 | y | Variable 'y' is not used. |
Expand Down
2 changes: 1 addition & 1 deletion rust/ql/test/query-tests/unusedentities/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ fn if_lets_matches() {
MyPoint { x: 3, y: a } => { // $ Alert[rust/unused-variable]
}
MyPoint { x: 4, .. } => {}
p => { // $ MISSING: Alert[rust/unused-variable]
p => { // $ Alert[rust/unused-variable]
}
}

Expand Down
Loading