Clean up JavaMinimizeDependencyJars feature flag
#3352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
379e7cb to
805b7e1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the fully rolled-out JavaMinimizeDependencyJars feature flag and simplifies the associated code. The feature flag check is replaced with a direct CodeQL version check (>= 2.23.0), and the special "minify-" cache key prefix for Java dependency caching is removed in favor of a consistent cache key format.
Key changes:
- Replaced feature flag check with direct version check in init-action logic
- Removed feature flag definition and configuration from feature-flags module
- Simplified cache key generation by removing Java-specific "minify-" prefix handling
- Removed tests for the deleted feature flag functionality
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/init-action.ts | Replaced feature flag check with CodeQL version check (>= 2.23.0) for enabling Java dependency jar minimization; added TODO for future refactoring |
| src/feature-flags.ts | Removed JavaMinimizeDependencyJars enum value and its configuration entry |
| src/dependency-caching.ts | Removed Java-specific logic for "minify-" prefix handling and simplified cache key assembly |
| src/dependency-caching.test.ts | Removed tests for the deleted Java minimization feature flag |
| lib/*.js | Auto-generated JavaScript files reflecting the TypeScript source changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature flag has been fully rolled out for some time, so we can simplify the code.
At the same time, stop using the
minify-prefix for dependency cache keys.There is still some Java-specific code to set the corresponding extractor option. I've left a TODO comment and will open an internal issue for a more principled way of handling that.
Risk assessment
For internal use only. Please select the risk level of this change:
The feature flag being removed is fully rolled out, so this PR should have no observable effects.
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, CCR, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.Environments:
github.com.How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist