Warn when review comment payload may be truncated #1579
+72
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a heuristic warning to the get_review_comments method when the marshaled payload exceeds approximately 8KB. This helps AI agents identify when MCP clients may truncate responses, suggesting they retry with a smaller perPage parameter to avoid missing comments.
Key changes:
- Introduced a threshold constant (8KB) to detect potentially truncated payloads
- Modified the response format to include a warning message when the threshold is exceeded
- Added comprehensive test coverage for the large payload warning scenario
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/github/pullrequests.go | Added mcpLargePayloadWarningThresholdBytes constant and logic to return a multi-content result (warning + data) when payload size exceeds threshold |
| pkg/github/pullrequests_test.go | Added unit test that creates a large payload scenario and verifies both warning and data content are returned correctly |
ewanlister-jpg
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a small heuristic warning to
pull_request_read:get_review_commentswhen the marshaled payload is large enough that some MCP clients may truncate it.Motivation: large review comments (big
diff_hunk/bodies) can cause the tool response to be cut off, hiding later comments and confusing agents. The warning suggests retrying with a smallerperPage.Changes:
pkg/github/pullrequests.go: if payload > ~8KB, return a leading WARNING text block plus the JSON.pkg/github/pullrequests_test.go: new unit test covering the warning path.Behavior is unchanged for normal-sized payloads.